Conversation
…c images in parallel Then creating and pushing a multi-arch manifest in a separate step. This allows us to build for amd64 and arm64 simultaneously, reducing overall build time.
andrewn617
left a comment
There was a problem hiding this comment.
This is great.
Just a couple suggestions but glad we are improving this :D
|
@copilot can you address the comments here? |
Agent-Logs-Url: https://github.com/rails/devcontainer/sessions/ef2fb079-610d-4b64-b61b-851dd2c2d34f Co-authored-by: rafaelfranca <47848+rafaelfranca@users.noreply.github.com>
Addressed in c6f5c2c. I updated the workflow to set up Ruby from Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot the environment variables are still being passed as arguments. We should just read the environment in the |
Agent-Logs-Url: https://github.com/rails/devcontainer/sessions/23db5954-a602-4ea7-94c3-bd7a0be7c1f5 Co-authored-by: rafaelfranca <47848+rafaelfranca@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rails/devcontainer/sessions/23db5954-a602-4ea7-94c3-bd7a0be7c1f5 Co-authored-by: rafaelfranca <47848+rafaelfranca@users.noreply.github.com>
Implemented in 764953e: the workflow now runs Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot hmmm. It seems publish-images-reusable is appearing as a worflow you can run. It should not |
Make image build faster by avoid using emulation to build arm64 images. Instead, have the image built in arm64 ubuntu machines.
The actions also got improved removing duplication and making easier to trigger in the interface.